Hi!
This patch should resolve the unicode issues that arise due to the use of regex-compat.
I haven't tested this on Windows, but I think it should work just fine.
A little illustratrion for the patch:
--------------------------------------------------
dan@aquabox sandboxed : ~/projects/darcs/screened
[0] % darcs --version
2.9.8 (+ 20 patches)
dan@aquabox sandboxed : ~/projects/darcs/screened
[0] % darcs changes --summary --match "hunk inexistant" --max-count=1
darcs failed: Text.Regex.Posix.String died: (ReturnCode 17,"illegal byte sequence")
dan@aquabox sandboxed : ~/projects/darcs/screened
[2] % ./dist/build/Darcs/darcs changes --summary --match "hunk inexistant" --max-count=1
Fri Mar 16 02:35:18 MSK 2012 Michael Hendricks <michael@ndrix.org>
* Style and error message clean up for patch733
M ./src/Darcs/Commands/Move.hs -3 +6 r3
--------------------------------------------------
1 patch for repository http://darcs.net:
Sun Feb 9 16:05:56 MSK 2014 Dan Frumin <difrumin@gmail.com>
* resolve issue2357: switching to regex-compat-tdfa for unicode support
This patch has a whitespace change in the array dependency in the cabal
file which I think is unnecessary and causes a conflict with current
screened - would you be able to amend that out?
Hi, Ganesh.
The 'array' line change was so that all requirements stack nicely together.
I can see now that it caused conflict. I've attached a rebased patch
On Fri, Feb 14, 2014 at 11:30 AM, Ganesh Sittampalam <bugs@darcs.net> wrote:
>
> Ganesh Sittampalam <ganesh@earth.li> added the comment:
>
> This patch has a whitespace change in the array dependency in the cabal
> file which I think is unnecessary and causes a conflict with current
> screened - would you be able to amend that out?
>
> ----------
> assignedto: -> DaniilFrumin
> status: needs-screening -> followup-requested
>
> __________________________________
> Darcs bug tracker <bugs@darcs.net>
> <http://bugs.darcs.net/patch1121>
> __________________________________
--
Sincerely yours,
-- Daniil
Apologies - I didn't realise the whitespace change had a purpose. I'd
have just resolved the conflict if I had. Anyway, thanks for the rebased
version, I've pushed to screened. It does build on Windows but I haven't
tested yet.