darcs

Patch 1121 resolve issue2357: switching to regex-compat-tdfa for ...

Title resolve issue2357: switching to regex-compat-tdfa for ...
Superseder Nosy List DaniilFrumin
Related Issues
Status accepted Assigned To
Milestone

Created on 2014-02-09.12:10:10 by DaniilFrumin, last changed 2014-04-23.18:06:08 by darcswatch. Tracked on DarcsWatch.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt DaniilFrumin, 2014-02-09.12:10:09 text/x-darcs-patch
resolve-issue2357_-switching-to-regex_compat_tdfa-for-unicode-support.dpatch dead DaniilFrumin, 2014-02-09.12:10:09 application/x-darcs-patch
resolve-issue2357_-switching-to-regex_compat_tdfa-for-unicode-support.dpatch DaniilFrumin, 2014-02-14.12:58:51 application/octet-stream
unnamed DaniilFrumin, 2014-02-09.12:10:09
See mailing list archives for discussion on individual patches.
Messages
msg17184 (view) Author: DaniilFrumin Date: 2014-02-09.12:10:09
Hi! 

This patch should resolve the unicode issues that arise due to the use of regex-compat. 
I haven't tested this on Windows, but I think it should work just fine.

A little illustratrion for the patch:

--------------------------------------------------
dan@aquabox sandboxed : ~/projects/darcs/screened
[0] % darcs --version
2.9.8 (+ 20 patches)

dan@aquabox sandboxed : ~/projects/darcs/screened
[0] % darcs changes --summary --match "hunk inexistant" --max-count=1

darcs failed:  Text.Regex.Posix.String died: (ReturnCode 17,"illegal byte sequence")

dan@aquabox sandboxed : ~/projects/darcs/screened
[2] % ./dist/build/Darcs/darcs changes --summary --match "hunk inexistant" --max-count=1
Fri Mar 16 02:35:18 MSK 2012  Michael Hendricks <michael@ndrix.org>
  * Style and error message clean up for patch733


    M ./src/Darcs/Commands/Move.hs -3 +6 r3
--------------------------------------------------

1 patch for repository http://darcs.net:

Sun Feb  9 16:05:56 MSK 2014  Dan Frumin <difrumin@gmail.com>
  * resolve issue2357: switching to regex-compat-tdfa for unicode support
Attachments
msg17199 (view) Author: ganesh Date: 2014-02-14.07:30:46
This patch has a whitespace change in the array dependency in the cabal 
file which I think is unnecessary and causes a conflict with current 
screened - would you be able to amend that out?
msg17201 (view) Author: DaniilFrumin Date: 2014-02-14.12:58:51
Hi, Ganesh.

The 'array' line change was so that all requirements stack nicely together.

I can see now that it caused conflict. I've attached a rebased patch

On Fri, Feb 14, 2014 at 11:30 AM, Ganesh Sittampalam <bugs@darcs.net> wrote:
>
> Ganesh Sittampalam <ganesh@earth.li> added the comment:
>
> This patch has a whitespace change in the array dependency in the cabal
> file which I think is unnecessary and causes a conflict with current
> screened - would you be able to amend that out?
>
> ----------
> assignedto:  -> DaniilFrumin
> status: needs-screening -> followup-requested
>
> __________________________________
> Darcs bug tracker <bugs@darcs.net>
> <http://bugs.darcs.net/patch1121>
> __________________________________



-- 
Sincerely yours,
-- Daniil
Attachments
msg17202 (view) Author: ganesh Date: 2014-02-15.21:40:34
Apologies - I didn't realise the whitespace change had a purpose. I'd 
have just resolved the conflict if I had. Anyway, thanks for the rebased 
version, I've pushed to screened. It does build on Windows but I haven't 
tested yet.
msg17203 (view) Author: darcswatch Date: 2014-02-15.21:46:06
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/screened.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_screened.html#bundle-92b7d78b60ae41b472380641792f59ebd2c685c8
msg17386 (view) Author: gh Date: 2014-04-23.17:46:41
According to the Stack Overflow thread linked from the issue thread,
this seems like the right thing to do.  Accepting it.
msg17391 (view) Author: darcswatch Date: 2014-04-23.18:06:08
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/reviewed.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-92b7d78b60ae41b472380641792f59ebd2c685c8
History
Date User Action Args
2014-02-09 12:10:10DaniilFrumincreate
2014-02-14 07:30:48ganeshsetstatus: needs-screening -> followup-requested
assignedto: DaniilFrumin
messages: + msg17199
2014-02-14 12:58:52DaniilFruminsetfiles: + resolve-issue2357_-switching-to-regex_compat_tdfa-for-unicode-support.dpatch
messages: + msg17201
2014-02-14 13:00:15darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-92b7d78b60ae41b472380641792f59ebd2c685c8
2014-02-15 21:40:35ganeshsetstatus: followup-requested -> needs-review
assignedto: DaniilFrumin ->
messages: + msg17202
2014-02-15 21:46:06darcswatchsetmessages: + msg17203
2014-04-23 17:46:41ghsetstatus: needs-review -> accepted
messages: + msg17386
2014-04-23 18:06:08darcswatchsetmessages: + msg17391