The new doFastZip' function can now create zip archives from arbitrary
located repositories; does not write the result to the file immediately.

You can pull the patch from my DarcsDen repository:
http://hub.darcs.net/co-dan/darcs-soc/patch/20150507135812-21ae5

Attachments

• fastzip.dpatch

This should go into the 2.10 branch so darcsden can use it

Actually, this breaks the dist.sh test. Daniil, could you check that?

Apologies for not looking at this patch earlier btw.

Hm, actually it works fine for me:

~/p/d/darcs-soc ❯❯❯ ./dist/build/darcs-test/darcs-
test
--tests=dist.sh

Using darcs executable in
/Users/dan/projects/darcs/darcs-soc/dist/build/darcs/darcs
Locale encoding is UTF-8

dist.sh (Darcs2) (PatienceDiff): [Success]

issue1269_setpref_predist.sh (Darcs2) (PatienceDiff): [Success]

         Shell       Total
 Passed  2           2
 Failed  0           0
 Total   2           2

What exact sequence of patches are you using, and what system are you on?

On Fri, May 29, 2015 at 12:32 PM, Ganesh Sittampalam <bugs@darcs.net> wrote:

>
> Ganesh Sittampalam <ganesh@earth.li> added the comment:
>
> Actually, this breaks the dist.sh test. Daniil, could you check that?
>
> Apologies for not looking at this patch earlier btw.
>
> ----------
> assignedto: gh -> DaniilFrumin
> milestone: 2.10.0 ->
>
> __________________________________
> Darcs bug tracker <bugs@darcs.net>
> <http://bugs.darcs.net/patch1332>
> __________________________________
>



-- 
Sincerely yours,
-- Daniil

Attachments

• unnamed

This is where it goes wrong - note that it's conditional on 'unzip' being present:

    | # Only do following if unzip is present
    | unzip >& /dev/null &&
    | (
    | unzip temp1.zip
    | diff -r temp_orig temp1
    | rm -rf temp1
    | )
    | + unzip
    | + unzip temp1.zip
    | :  mismatching "local" filename (file-4),
    |          continuing with "central" filename version
    | mapname:  conversion of  failed

I'm running NixOS (commit 37e2733) and I've got this:

    $ unzip -v
    UnZip 6.00 of 20 April 2009, by Info-ZIP.

I suspect it's because we're now creating paths starting "./foo" where they were previously "foo".

I think I might have figured it out. Here is an updated patch. It also
fixes another mistake in the previous patch: the message ("Created ...zip")
was erroneously omitted.


On Sat, May 30, 2015 at 3:13 PM, Ganesh Sittampalam <bugs@darcs.net> wrote:

>
> Ganesh Sittampalam <ganesh@earth.li> added the comment:
>
> This is where it goes wrong - note that it's conditional on 'unzip' being
> present:
>
>     | # Only do following if unzip is present
>     | unzip >& /dev/null &&
>     | (
>     | unzip temp1.zip
>     | diff -r temp_orig temp1
>     | rm -rf temp1
>     | )
>     | + unzip
>     | + unzip temp1.zip
>     | :  mismatching "local" filename (file-4),
>     |          continuing with "central" filename version
>     | mapname:  conversion of  failed
>
> I'm running NixOS (commit 37e2733) and I've got this:
>
>     $ unzip -v
>     UnZip 6.00 of 20 April 2009, by Info-ZIP.
>
> I suspect it's because we're now creating paths starting "./foo" where
> they were previously "foo".
>
> __________________________________
> Darcs bug tracker <bugs@darcs.net>
> <http://bugs.darcs.net/patch1332>
> __________________________________
>

Attachments

• generalize-darcs_ui_commands_dist_dofastzip.dpatch
• unnamed

The old patch is already applied, so please could you make the new one 
a follow-on rather than an amendment?

Oops, sorry for that.

On Sun, Jun 7, 2015 at 10:18 PM, Ganesh Sittampalam <bugs@darcs.net> wrote:

>
> Ganesh Sittampalam <ganesh@earth.li> added the comment:
>
> The old patch is already applied, so please could you make the new one
> a follow-on rather than an amendment?
>
> __________________________________
> Darcs bug tracker <bugs@darcs.net>
> <http://bugs.darcs.net/patch1332>
> __________________________________
>

Attachments

• fix-the-previous-dofastzip-patch.dpatch
• unnamed

1 patch for repository darcs-unstable@darcs.net:screened:

Mon Jun  8 07:44:49 BST 2015  Ganesh Sittampalam <ganesh@earth.li>
  * fix warning

Attachments

• fix-warning.dpatch
• patch-preview.txt
• unnamed

Looks good now, thanks!

I'm pushing the 3 patches into branch 2.10.

2015-06-08 14:28 GMT-03:00 Ganesh Sittampalam <bugs@darcs.net>:
>
> Ganesh Sittampalam <ganesh@earth.li> added the comment:
>
> Looks good now, thanks!
>
> __________________________________
> Darcs bug tracker <bugs@darcs.net>
> <http://bugs.darcs.net/patch1332>
> __________________________________