Smoother hijack interaction for rebase

4 patches for repository http://darcs.net:

patch 35184aa9f8945edbfd66ad8004c021e3ffce49cd
Author: Eric Kow <kowey@darcs.net>
Date:   Sat Sep 19 13:30:08 CEST 2015
  * Helper to capitalize a sentence

patch 1153b7333b4a5863e892a9b2bca253fd281e15d2
Author: Eric Kow <kowey@darcs.net>
Date:   Sat Sep 19 17:16:14 CEST 2015
  * Generalise hijack warning to support use in other commands

patch 47fcd663130c06702096233b8ace6e72a792ba7f
Author: Eric Kow <kowey@darcs.net>
Date:   Sun Sep 20 13:37:03 CEST 2015
  * resolve issue2276: Keep track of patch hijack decisions

patch e84bfcfe089f9927eec61d0b6e26158a689aa57e
Author: Eric Kow <kowey@darcs.net>
Date:   Sun Sep 20 13:56:48 CEST 2015
  * resolve issue2269: push hijack test to suspend time
  
  This will happen after you've selected patches to suspend.
  We assume here that unsuspend can then safely ignore the hijack
  attempts
  
  Note that this is a bit all-or-nothing. For fancier behaviour,
  we would need to weave this into SelectChanges

Attachments

• helper-to-capitalize-a-sentence.dpatch
• patch-preview.txt
• unnamed

Note that the behaviour of unsuspend ignoring hijacks assumes that patches are 
only suspended by rebase suspend.  For rebase pull/apply, we'd either need to 
do the hijack check or be smarter somehow

I guess if you are about to unsuspend someone's else patch it's already too late to do a hijack check :)

What would the behavior of rebase pull/apply be? I guess we want to display a warning before any foreign patches are suspended. 

> On 20 Sep 2015, at 16:14, Eric Kow <bugs@darcs.net> wrote:
> 
> 
> Eric Kow <kowey@darcs.net> added the comment:
> 
> Note that the behaviour of unsuspend ignoring hijacks assumes that patches are 
> only suspended by rebase suspend.  For rebase pull/apply, we'd either need to 
> do the hijack check or be smarter somehow
> 
> __________________________________
> Darcs bug tracker <bugs@darcs.net>
> <http://bugs.darcs.net/patch1396>
> __________________________________
> _______________________________________________
> darcs-devel mailing list
> darcs-devel@darcs.net
> http://lists.osuosl.org/mailman/listinfo/darcs-devel

2 patches for repository darcs-unstable@darcs.net:screened:

patch 7dc9909ce8b05e971ea0d8541157719c677c7745
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Fri Oct 23 06:16:00 BST 2015
  * be a bit clearer about patch names in hijack test

patch 9a759c16a9108fdb312d5c239e4a61c145b9fd4e
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Fri Oct 23 06:16:43 BST 2015
  * warn when suspending "hijacked" patches in rebase pull and apply

Attachments

• be-a-bit-clearer-about-patch-names-in-hijack-test.dpatch
• patch-preview.txt
• unnamed

This looks good. I've added a simple followup to do the same check in 
rebase pull/apply. The code change for that is a trivial copy of the 
existing code so I'm marking the whole lot as reviewed.