darcs

Patch 1702 maintenance/test system patches

Title maintenance/test system patches
Superseder Nosy List bf
Related Issues
Status accepted Assigned To
Milestone

Created on 2018-07-17.14:29:51 by bf, last changed 2018-07-27.16:55:25 by ganesh.

Files
File name Status Uploaded Type Edit Remove
consistently-use-skip_formats-from-tests_lib-in-test-scripts.dpatch bf, 2018-07-17.14:29:50 text/x-darcs-patch
extended-test-for-issue1522-with-success-case.dpatch bf, 2018-07-23.07:25:06 application/x-darcs-patch
re_add-test-for-issue1609.dpatch bf, 2018-07-17.15:06:59 text/x-darcs-patch
See mailing list archives for discussion on individual patches.
Messages
msg20193 (view) Author: bf Date: 2018-07-17.14:29:50
Various fixes to the test scripts, the harness and one to authorspellings.
Attachments
msg20194 (view) Author: bf Date: 2018-07-17.14:32:33
Screening this bundle immediately (test and repo related changes only)
msg20195 (view) Author: bf Date: 2018-07-17.14:33:43
Oops, forgot to paste the patch list, here we go

13 patches for repository http://darcs.net/screened:

patch 6c2b173cc853f71fe57f86755944c94bb43ca0ac
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Wed Apr 25 18:34:02 CEST 2018
  * consistently use skip-formats from tests/lib in test scripts

patch c32b591c413dfcc65e2dab57908ffad3451f9824
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Mar 28 01:31:36 CEST 2018
  * added my HZB email to .authorspellings

patch 1532c37d49cd656f32b6591ebdf2c5746a756fe7
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Mar  9 10:42:12 CET 2018
  * harness: improve output when property invertRollback fails

patch d916f522c48ebb2dd4521e40b0d28ebc861733e4
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Jun  7 17:35:13 CEST 2018
  * issue1522 is not failing, we just tested the wrong thing
  
  The issue, as originally reported, was that darcs did /not/ fail here.
  The test now checks that it does and thus succeeds as required.

patch f14e209479e6b216052eff0e4197b65d6f526466
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Jun  8 13:04:41 CEST 2018
  * add a failing test for resolution of conflict chains

patch c4291b60f70cc1fdd7aeff68f7e782e4ea0cd1ef
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat Jun  9 10:39:54 CEST 2018
  * fix clone-http-packed tests
  
  It seems newer versions of lighttpd need an empty list for the
  index-file.name configuration setting, otherwise requests for directories
  cannot be served.result in a 404 error.

patch b84aa804d9ebc45b9b9a7ccdcfa18dbf07de94d0
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Jun 13 10:03:33 CEST 2018
  * renamed and fixed test for issue 2548

patch eded2c680e53f03bff04afe1e952413674bdeed9
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Jun 14 18:41:16 CEST 2018
  * fix a wrong comment in failing test for issue1610

patch 0b618eeb661bcab931ec3a222250210195b0663a
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Jun 14 20:15:16 CEST 2018
  * issue1461 is no longer failing

patch cbb70bf09e10fb3a4c7a7cbecad6e4d7dfadd10c
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Jun 15 12:55:41 CEST 2018
  * tests: remove an mkdir for an unused test dir

patch 9a961ee2f36e5a5b1a27646aad7105a9d3e69ba9
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Jun 27 10:55:23 CEST 2018
  * fix a few tests that erroneously fail when run with --testdir

patch 10ae634f4aa0132cd9754c4773d7107836af2140
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Jun 27 11:04:04 CEST 2018
  * tests: cleanup chmod -w else cannot remove testdir

patch 770fa1e9d3dfcaf902e6b5a803957584afe0ee1c
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Jul 13 16:02:01 CEST 2018
  * in a few test scripts, clean test repos before creating them
msg20196 (view) Author: bf Date: 2018-07-17.15:06:59
Forgot to send one more test change. It is attached in a separate bundle.

patch 205c25351234da4e5bb9d25fa59e68aeaa9fe672
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Jun 14 20:12:58 CEST 2018
  * re-add test for issue1609
Attachments
msg20220 (view) Author: ganesh Date: 2018-07-22.20:02:22
* consistently use skip-formats from tests/lib in test scripts

Fine

  * added my HZB email to .authorspellings
Fine

  * harness: improve output when property invertRollback fails
Fine

  * issue1522 is not failing, we just tested the wrong thing

Fine
A follow-up improvement would be to make this test also check that 
the syntax does work on directories.

  * add a failing test for resolution of conflict chains

The test script isn't ideal as even if darcs produced the conflict 
sets you expect, they might not be in that order.
But someone can probably fix it up at that point, it's not worth 
trying to be order-insensitive in shell.

  * fix clone-http-packed tests

Fine (Note to self - need to run the tests on Linux before 
accepting, as they don't work for me on Windows anyway)

  * renamed and fixed test for issue 2548

Fine

  * fix a wrong comment in failing test for issue1610

Fine

  * issue1461 is no longer failing

Fine (it would be nice to have had a bit more info in the patch 
comment about the removal of the lines that guarded for a case-
insensitive filesystem)

  * tests: remove an mkdir for an unused test dir

Fine

  * fix a few tests that erroneously fail when run with --testdir

Fine

  * tests: cleanup chmod -w else cannot remove testdir

Fine

  * in a few test scripts, clean test repos before creating them

Fine

  * re-add test for issue1609

Fine
msg20224 (view) Author: bf Date: 2018-07-23.07:25:06
attached is the follow-up patch to extend the test for issue1522
Attachments
msg20228 (view) Author: ganesh Date: 2018-07-27.16:55:25
Thanks!
History
Date User Action Args
2018-07-17 14:29:51bfcreate
2018-07-17 14:32:34bfsetstatus: needs-screening -> needs-review
messages: + msg20194
2018-07-17 14:33:43bfsetmessages: + msg20195
2018-07-17 15:06:59bfsetfiles: + re_add-test-for-issue1609.dpatch
messages: + msg20196
2018-07-22 20:02:32ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg20220
2018-07-23 07:25:06bfsetfiles: + extended-test-for-issue1522-with-success-case.dpatch
messages: + msg20224
2018-07-27 16:55:25ganeshsetstatus: accepted-pending-tests -> accepted
messages: + msg20228