It's hard to look at --patch-name and --patch and tell how they are
different. Each is documented in the help/manual adequately, but a good UI
would not present them together (as with amend-record), without giving them
names that help differentiate them.
See for example issue1778.
So, my proposal is a renaming of these options (yes, that makes it an icky
UI change) in order to prevent this sort of confusion. If they couldn't be
passed to a command at the same time it would be less of an issue. Since
they can be passed at the same time my 'wish' is for them to be more
different.
The fact that a user was confused enough to take the time to write a bug
report and then several devs looked at the report before catching the
confusion points to the depth of the confusion, especially for new users.
Example new names:
--set-patch-name and --patch-name-matching
--new-patch-name and --find-patch-name
--set-name and --name-matching
--set-name and --find-named
etc.
There should probably be some consensus on the best new names. For reaching
consensus, I propose making a list of 6, or so, alternatives and then
holding a closed-ended multiple choice poll. Then using the top voted
option.
Jason
|