darcs

Issue 872 darcs: bug in darcs! Impossible case src/Lcs.lhs:173 compiled May 21 2008 09:16:51 at src/Lcs.lhs:173 compiled May 21 2008 09:16:51

Title darcs: bug in darcs! Impossible case src/Lcs.lhs:173 compiled May 21 2008 09:16:51 at src/Lcs.lhs:173 compiled May 21 2008 09:16:51
Priority bug Status duplicate
Milestone Resolved in
Superseder patch for darcs - fix for LCS
View: 871
Nosy List darcs-devel, dmitry.kurochkin, kowey, thorkilnaur, tommy, zooko
Assigned To
Topics

Created on 2008-05-21.19:48:44 by zooko, last changed 2009-08-27.13:59:45 by admin.

Messages
msg4823 (view) Author: zooko Date: 2008-05-21.19:48:36
darcs compiled on May 21 2008, at 09:18:59
# configured Wed May 21 09:16:28 MDT 2008
./configure /home/zooko/stow/darcs-2/share/config.site /home/zooko/ 
stow/darcs-2/etc/config.site

Context:

[getChanges with better shifting of first and last hunk with  
shiftBoundaries
Pekka Pessi <pekka.pessi@nokia.com>**20080521113655

  The one-line context left with old dropStart and dropEnd is not always
  enough. As a consequence first and last hunk in the file got treated
  inconsistently by shiftBoundaries.

  The refactored code converts lists into PArrays already by getChanges,
  dropStart and dropEnd advance bounds within PArray.

  getChanges' handles PArrays, and refactored code introduces minor
  optimizations to hash handling (collisions within one file are not
  propagated to diffArr).
]

[Generalise test for rollback with no changes.
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080521120856]

[Fix UI bug in rollback.
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080521120359
  It did not notice if you do not select any changes to roll back.
]

[resolve issue855: fix bug where we were calling revertRepository  
when running with --dry-run.
David Roundy <droundy@darcs.net>**20080521131419]

[Undo overoptimistic move of issue855 bug to tests.
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080521102935

  The test had some errors (some of which I introduced during the move)
  which caused it to pass for the wrong reason.  This patch also
  corrects those bugs so that it fails like it should.
]

[resolve issue687: don't clean out pristine cache except when  
optimizing.
David Roundy <droundy@darcs.net>**20080521120834
  The trouble is that we can never tell when someone might be waiting  
to grab
  one of these older files.  Atomicity doesn't gain us much if we  
drop the
  old files immediately.  The downside is that now repositories will
  monotonically grow until an optimize is performed.  :(
]

[simplify setpref.sh
David Roundy <droundy@darcs.net>**20080521113817]

[resolve issue870: it was a bug in the test script.
David Roundy <droundy@darcs.net>**20080521113233]

[Add failing test for issue870.
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080521102151]

[Move issue855 bug to tests.
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080520152055]

[Resolve issue855: avoid taking lock if using --dry-run
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080519143535]

[add some checks that repo isn't modified when --dry-run is used.
David Roundy <droundy@darcs.net>**20080520143945]

[Add (passing) test for issue709.
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080519144425]

[Canonize Pekka Pessi (yet again).
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080519143516]

[Replace presumably non-portable use of fgrep in issue864 bug
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080519143303]

[Add a test for issue855 (push --dry-run)
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080517154246]

[Add a test to show a bug with --look-for-adds that corrupt pending.
Nicolas Pouillard <nicolas.pouillard@gmail.com>**20080520105715]

[Added bugs/replace-in-moved.sh for bug 864.
Pekka.Pessi@nokia.com**20080519141801]

[Fix import warnings for Windows.
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080517160935
  They are caused by Lele's recent patches.
]

[English: only use singular for 1 (we have 0 foos, but 1 bar, and 2  
quuxes)
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080517152737]

[automatically include --xml support on commands supporting --dry-run.
David Roundy <droundy@darcs.net>**20080517123224]

[Honour --xml-output when printing the patches in the "will  
do"/"would do" message
lele@nautilus.homeip.net**20080517110820]

[Wrap ShowRepo output within a <repository> tag, when asked for XML  
output
lele@nautilus.homeip.net**20080514174050]

[remove unused GHC_LIBDIR
David Roundy <droundy@darcs.net>**20080516161816]

[we don't need a reminder when there are no patches to pull.
David Roundy <droundy@darcs.net>**20080516115858]

[simplify init_tmp_repo.
David Roundy <droundy@darcs.net>**20080516113713]

[simplify calling of darcs in perl harness.
David Roundy <droundy@darcs.net>**20080516113619]

[clean up shell_harness just a tad.
David Roundy <droundy@darcs.net>**20080516111416]

[fix perl harness to use the right darcs.
David Roundy <droundy@darcs.net>**20080516111316]

[make pull_compl.sh a bit more verbose.
David Roundy <droundy@darcs.net>**20080516110235]

[remove unnecessary defaults-setting in pull_compl.sh
David Roundy <droundy@darcs.net>**20080516105618]

[Fixed problems with --with-static-libs
Pekka Pessi <pekka.pessi@nokia.com>**20080515175414

  When linking statically, the libraries must be listed last.

  Using LIBS/OPTLLIBS to collect libraries.
]

[Zapped bash-ism from configure.ac.
Pekka Pessi <pekka.pessi@nokia.com>**20080515150932]

[Not using awk in configure.ac
Pekka Pessi <pekka.pessi@nokia.com>**20080515131700

  Plain sed does not grok +, use xx* instead of x+
]

[Resolve issue738: When pushing, remind user of patches to pull.
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080515184714]

[simplify update_roundup.pl.
David Roundy <droundy@darcs.net>**20080515160802
  This change also fixes the bug where a capitalized message such as
  "Resolved issue123:" would try to set a capitalized status.  We  
just don't
  so that much generality, and the generality lead to bugs.
]

[Resolve issue712: Rename --extended-help to --overview.
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080515151414]

[Do not react to darcs help --verbose
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080515143125

  It used to be the same as darcs --extended-help, but since we're
  renaming that to be darcs --overview, it seemed silly to be calling
  it 'verbose'
]

[+strictness comment in FPS.hs
gwern0@gmail.com**20080515043031]

[Resolve issue845: Pass ssh's stderr to our stderr.
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080514135504

  This may have the side effect that users get *a lot* of scp output  
dumped
  on their screen, but false 'hanging' that Zooko reported seems like  
the
  greater evil.  Note that darcs transfer-mode is not affected by  
this, so
  the only users that would see the extra output are those who are  
interacting
  with servers that don't have darcs 2 installed.
]

[Canonize Pekka Pessi (again).
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080513122318]

[Use nilPS wherever possible
Spencer Janssen <sjanssen@cse.unl.edu>**20080513122834]

[Remove unused UnsafeCatch module
Spencer Janssen <sjanssen@cse.unl.edu>**20080416090542]

[pipeDocToPager runs no pager if pager is "".
Pekka Pessi <pekka.pessi@nokia.com>**20080512154347

  Darcs does not run pager if DARCS_PAGER environment variable has  
empty value
  (or PAGER, if DARCS_PAGER is not set).

  This is like man uses MANPAGER or PAGER environment variables.
]

[Do pipeDocToPager withoutNonBlock.
Pekka Pessi <pekka.pessi@nokia.com>**20080512154126

  Pagers tend to fail if terminal is in non-blocking mode.
]

[Added withoutNonBlock to Exec.
Pekka Pessi <pekka.pessi@nokia.com>**20080512134145

  Now pipeDoc runs pager process without non-blocking IO mode.
]

[consistently indent index.html and make it validate
Simon Michael <simon@joyful.com>**20080418012452]

[Do not fix DarcsFlag (Output "-").
Pekka Pessi <pekka.pessi@nokia.com>**20080512162005

  -o- is used for output to stdout.
]

[don't inline darcs_version.
David Roundy <droundy@darcs.net>**20080511115315
  There's no need to inline it, and doing so requires extra  
recompiles every
  time it changes.
]

[use viewDocWith in printPatchPager and cut view_file function.
David Roundy <droundy@darcs.net>**20080511115112]

[only use pager on longer data.
David Roundy <droundy@darcs.net>**20080511114957
  This change also allows to print Docs to pager with whichever  
Printers we
  choose.
]

[Restore creation of temporary file when calling a pager.
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080510233252

  The way runProcess works now, we have to redirect the pager's  
stdout (?).
  For the pager, since it's not writing to a terminal, the sane thing  
for it
  to do is to just behave like cat.

  For now we just go back to the old behaviour of calling the pager  
with a
  temporary file as an argument.  The only difference here is that we
  create the temporary file in /tmp to avoid some of issue770.  This is
  safe because it's only the pager that uses the file, not us.
]

[resolve Issue803: add files back in that were manually moved on  
darcs mv.
David Roundy <droundy@darcs.net>**20080509202630]

[tiny wibble to make code a little more symmetric.
David Roundy <droundy@darcs.net>**20080509195930]

[resolve Issue739: compile with threaded runtime by default.
David Roundy <droundy@darcs.net>**20080509195833
  It turns out that the tempfile-removal cleanup wasn't particularly  
feasible
  without the threaded runtime.
]

[resolve Issue776: add code to wait for forkIO error-reporting  
threads to exit.
David Roundy <droundy@darcs.net>**20080509195804]

[make pipeDoc use System.Process.
David Roundy <droundy@darcs.net>**20080509193137
  This one was tricky, because we need to forward stderr and stdout  
from the
  process.  This ugly because of the limited API provided by  
System.Process.
  Ideally we'd let the child inherit both stderr and stdout, and we  
wouldn't
  need to have any of this forkIO and MVar complexity.
]

[clean up execPipeIgnoreError to use System.Process.
David Roundy <droundy@darcs.net>**20080509165812]

[Create temporary files in the current directory.
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080509153406
  We don't know how openBinaryTempFile behaves with an empty string
  as the directory.
]

[Create temporary files with openBinaryTempFile.
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080509145636
  Remove some mkstemp-related code which is no longer used.
]

[Use System.Directory.getTemporaryDirectory to determine tmp location.
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080509143035

  This is more portable.  For instance, it understands Windows's
  conventions.
]

[corrected ratification...
David Roundy <droundy@darcs.net>**20080509155411]

[ratify Eric's use of readFile.
David Roundy <droundy@darcs.net>**20080509150447]

[Fall back to stdout if viewing a file with a pager fails.
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080509122756

  This is related to issue770.  Note also that there is another
  function Darcs.External.viewDoc which does something similar.
]

[simplify pull_compl.sh just a tad.
David Roundy <droundy@darcs.net>**20080509120623]

[ignore any errors in clean_pristine.
David Roundy <droundy@darcs.net>**20080508203823
  This will now be triggered when running repair, and should be  
essentially
  harmless.
]

[cause check to fail if there are patches that remove non-empty files.
David Roundy <droundy@darcs.net>**20080508201818]

[resolve Issue815: enable rempair of "rm" patches that don't remove  
file contents.
David Roundy <droundy@darcs.net>**20080508201713
  Note that this doesn't fix the underlying bug that allowed these  
patches to
  be created, but at least it can help users with corrupt repositories.
]

[support patch fixing in PatchInfoAnd.
David Roundy <droundy@darcs.net>**20080507190933]

[avoid using "which" command, which is buggy on SunOS.
David Roundy <droundy@darcs.net>**20080507190521]

[make patchSetToRepository work on hashed repositories.
David Roundy <droundy@darcs.net>**20080507183543]

[move comment to last line of compile attempts in aclocal.m4.
David Roundy <droundy@darcs.net>**20080507145339]

[resolve Issue817: fix bug in conflict-handling with darcs-2 semantics.
David Roundy <droundy@darcs.net>**20080507144950
  This bug was due to the buggy use of a buggy function called
  depends_uponFL.  I've removed this function, and am making this note
  explicit so that noone else (including myself) will make the  
mistake of
  resurrecting this function from the past.
]

[update copyright info in aclocal.m4
David Roundy <droundy@darcs.net>**20080507144721]

[make conflict-fight-failure test a little more legible and verbose.
David Roundy <droundy@darcs.net>**20080507134927]

[Canonize Pekka Pessi.
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080507130033]

[Demonstrate conflict fight bug #817
Pekka Pessi <first.last@nokia.com>**20080507113647

  Too deep conflict fight ends with Inconsistent patch w/ conflictor.

  Use make bugs_shell_format2 for demonstration.

]

[Fix space issue in issue803.sh
lele@nautilus.homeip.net**20080507121137]

[fix weird bug in harness.sh maybe?
David Roundy <droundy@darcs.net>**20080506210002]

[make harness.sh a little more verbose.
David Roundy <droundy@darcs.net>**20080506191708]

[translate whatsnew.pl into shell.
David Roundy <droundy@darcs.net>**20080506145907]

[document running a couple of tests.
David Roundy <droundy@darcs.net>**20080506145001]

[document that we now can just use "darcs" in shell tests.
David Roundy <droundy@darcs.net>**20080506144944]

[remove darcs wrapper from tests.
David Roundy <droundy@darcs.net>**20080506144610]

[don't set the IFS variable to null in harness.
David Roundy <droundy@darcs.net>**20080506142954]

[simplify uniqueoptions.sh
David Roundy <droundy@darcs.net>**20080506142716]

[simplify tests a bit more.
David Roundy <droundy@darcs.net>**20080506141913]

[clean up before running issue436.sh.
David Roundy <droundy@darcs.net>**20080506135341]

[fix space issue in test.
David Roundy <droundy@darcs.net>**20080506135217]

[avoid unnecessary complexity in tests.
David Roundy <droundy@darcs.net>**20080506111116]

[modernize steve-and-monica test.
David Roundy <droundy@darcs.net>**20080506110739]

[simplify code to avoid having to worry about spaces in test path.
David Roundy <droundy@darcs.net>**20080506110534]

[fix pull_many_files.pl test to search for GNU tar first
Karel Gardas <kgardas@objectsecurity.com>**20080506065321]

[bugfix, --ask-deps needs with_selected_changes_reversed to ask the  
right questions
Tommy Pettersson <ptp@lysator.liu.se>**20080504161526]

[(re-)add with_selected_changes_reversed to SelectChanges
Tommy Pettersson <ptp@lysator.liu.se>**20080504161412
  This function is needed for the --ask-deps options to Record.
]

[add test for --ask-deps
Tommy Pettersson <ptp@lysator.liu.se>**20080501095450]

[slightly-prettier way to avoid using system shell's test function.
David Roundy <droundy@darcs.net>**20080505203320]

[simplify workaround for broken cp.
David Roundy <droundy@darcs.net>**20080505201614]

[add testsuite workarounds for Solaris `cp' and `test' commands issues
Karel Gardas <kgardas@objectsecurity.com>**20080505195605]

[included files reordering to fix build warning on Solaris
Karel Gardas <kgardas@objectsecurity.com>**20080505185453]

[make issue538 test work with spaces in directories.
David Roundy <droundy@darcs.net>**20080505184459]

[de-tapify issue538.sh test.
David Roundy <droundy@darcs.net>**20080505184239]

[remove recommendation to use TAP output for shell tests.
David Roundy <droundy@darcs.net>**20080505165808]

[resolve Issue832: quote all instances of "$DARCS", "$ACTUAL_DARCS",  
"$PWD", and "$HOME" in the sh tests and test harness, as well as all  
other shell variables that get expanded in test scripts (a cursory  
glance suggested that none of them were actually intended to be split  
on whitespace and so are probably best quoted).
zooko@zooko.com**20080503181651]

[Make curl_multi_timeout check work for static builds.
Dmitry Kurochkin <dmitry.kurochkin@gmail.com>**20080503212935]

[Move curl_multi_timeout check outside of pipelining check.
Dmitry Kurochkin <dmitry.kurochkin@gmail.com>**20080503212708]

[get rid of stupid debug messages.
David Roundy <droundy@darcs.net>**20080503203650]

[resolve conflict in aclocal.m4
David Roundy <droundy@darcs.net>**20080503195800]

[Do LDFLAGS conversion without calling out to GHC, avoiding nasty  
characters in GHC commands
Reinier Lamers <tux_rocker@reinier.de>**20080503192456]

[avoid putting a newline into GHCLIBS and/or GHCLDFLAGS.
David Roundy <droundy@darcs.net>**20080503180805]

[even more stupid debug messages.
David Roundy <droundy@darcs.net>**20080503171055]

[insert stupid debug code into configure script.
David Roundy <droundy@darcs.net>**20080503162856]

[resolve issue793: fix regression in 'before X' date matching
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080502213535

  It was probably introduced by trying to convert CalendarTimes to
  ClockTimes; when converting a zero CalendarTime to ClockTime, we get
  something before zero.
]

[resolve issue245: more precise 'Bad token spec' error messages.
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080502204426
  I think this resolves issue371 as well.
]

[Slight tidy up of English module.
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080502201151]

[mark issue803.sh test as a currently-failing bug.
David Roundy <droundy@darcs.net>**20080502185438]

[Added test for issue 803
lele@nautilus.homeip.net**20080501233629]

[use bash in test.
David Roundy <droundy@darcs.net>**20080502184149]

[Fix test for issue 538
tux_rocker@reinier.de**20080502154349]

[Added test for issue 538
tux_rocker@reinier.de**20080501221528]

[issue 538: set scripts executable before test if user desires
tux_rocker@reinier.de**20080501203644]

[resolve Issue813: make configure test consult LDFLAGS and LIBS.
David Roundy <droundy@darcs.net>**20080502160200]

[add another test for Issue794.
David Roundy <droundy@darcs.net>**20080502160111]

[Correct how darcs treats identical changes under darcs-2 format
lele@nautilus.homeip.net**20080502084118]

[prefer catMaybes over list comprehension.
David Roundy <droundy@darcs.net>**20080502153330]

[Move repoformat bug to passing tests.
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080501223603]

[resolve issue794: don't stop on first repoformat success.
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080501223923

  Unfortunately, this bug means that older versions darcs might not be
  aware of potential forwards-compatibility issues, where the new,
  unrecognised lines in repoformat come after a familiar one.
]

[doc: msmtp -t (for multiple recipients)
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080501224701

  When I used --sendmail-command="msmtp %t %<" to send a patch to the  
darcs
  darcs repository, I got the following error:

    PERM_FAILURE: Probe failed: Illegal To: address (invalid domain  
name):
    droundy@darcs.net, darcs-users@darcs.net

  Using -t in sendmail mode causes msmtp to read the recipients from the
  message itself, which I suppose works better than passing them in via
  the command line.
]

[resolve issue827: correct changes -i behaviour
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080502090907

  Promised old behaviour:
      Shall I view this patch?
       y - view this patch; keep going
       n - do not view this patch; keep going [DEFAULT]
       v - view this patch; keep going
       q - quit

  Actual old behaviour:
      Shall I view this patch?
       y - view this patch; stay put
       n - do not view this patch; keep going [DEFAULT]
       v - view this patch; stay put
       q - quit

  New behaviour:
      Shall I view this patch?
       y - view this patch; keep going
       n - do not view this patch; keep going [DEFAULT]
       v - view this patch; stay put
       q - quit
]

[Correct changes -i help message.
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080502090655]

[Use `curl-config --static-libs` when building with static libs.
Dmitry Kurochkin <dmitry.kurochkin@gmail.com>**20080502115703]

[resolve issue283: Make darcs help <cmd> consistent with darcs <cmd>  
--help.
Nicolas Pouillard <nicolas.pouillard@gmail.com>**20080502123521

  darcs help <cmd>, no longer print the darcs version.
]

[reorder test suite around fact that test_unit takes so long.
David Roundy <droundy@darcs.net>**20080501113207]

[remove gitlib.{c,h.in} as it appears to be unused
Jason Dagit <dagit@codersbase.com>**20080501002306]

[refactor "_darcs" to darcsdir variable
Jason Dagit <dagit@codersbase.com>**20080501042650]

[change handling of hi files to use silly make rule as ghc docs suggest.
David Roundy <droundy@darcs.net>**20080501105800]

[enable automatic running of additional tests, as Gwern suggested.
David Roundy <droundy@darcs.net>**20080501105606]

[generalize the testing for external libraries.
David Roundy <droundy@darcs.net>**20080430232912]

[Use GHC instead of GCC to check for zlib availability (issue 813)
tux_rocker@reinier.de**20080430220105]

[resolve issue76: update docs on temp directory creation.
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080430175713]

[Add test for issue794.
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080430165251]

[doc: encourage new users to use --darcs-2 repositories.
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080425172110
  Note that this is sans explanation (in the getting started section).
  Maybe new users might be put off by the mystery flag?
]

[doc: tell users about darcs-2 handling of identical patches.
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080425172104
  Do not bother talking about darcs-1 behaviour.
]

[add test for darcs show bug.
David Roundy <droundy@darcs.net>**20080430165425]

[fix bug in configure script wrt HTTP package.
David Roundy <droundy@darcs.net>**20080430165350]

[cleanup in ShowAuthors: "as" is a bad variable name, since it's also  
a haskell keyword.
David Roundy <droundy@darcs.net>**20080430161237]

[add very simple test for show authors.
David Roundy <droundy@darcs.net>**20080430161222]

[Ordered.lhs: explain acronyms
gwern0@gmail.com**20080429203213]

[Prefs.lhs: add cabal intermediates to ignore
gwern0@gmail.com**20080429201917
  Re-send, not depending on rejected patches.
]

[remove unused function ephemeral.
David Roundy <droundy@darcs.net>**20080429163057]

[remove unused compress/uncompress functions.
David Roundy <droundy@darcs.net>**20080429162552]

[remove unneeded --verify-hash flag (we always verify hashes).
David Roundy <droundy@darcs.net>**20080429162303]

[remove Stringalike module entirely.
David Roundy <droundy@darcs.net>**20080429155919]

[cut commented code (that would no longer compile).
David Roundy <droundy@darcs.net>**20080429155455]

[eliminate use of Stringalike in ReadMonad and friends.
David Roundy <droundy@darcs.net>**20080429155158]

[simplify ParserM
David Roundy <droundy@darcs.net>**20080429153800]

[make PatchInfo reading specific to PackedString.
David Roundy <droundy@darcs.net>**20080429152300]

[remove unused function test_patch.
David Roundy <droundy@darcs.net>**20080429150504]

[remove unused emptyFileContents.
David Roundy <droundy@darcs.net>**20080429150154]

[remove unused isExecutable function.
David Roundy <droundy@darcs.net>**20080429145721]

[Prefs.lhs: ignore .darcsrepo as well
gwern0@gmail.com**20080429012932
  Add it now, since we're going to get .darcsrepo at some point.
]

[Prefs.lhs: ignore zsh-compiled files and Gentoo/X leftover files
gwern0@gmail.com**20080429010201]

[Prefs.lhs: ignore .git
gwern0@gmail.com**20080429010115]

[Prefs.lhs: ignore profiling intermediate files
gwern0@gmail.com**20080429010050]

[Diff.lhs, Prefs.lhs: add docs for 4096 optimization
gwern0@gmail.com**20080427234109]

[Diff.lhs: has_bin only inspects first 4096 characters
gwern0@gmail.com**20080427233947
  This is an optimization for large files, it saves running has_funky  
on gigs and gigs of data when pretty much all binary files give the  
truth away within a few characters.
]

[fpstring.c: switch a memchr for memrchr
gwern0@gmail.com**20080425200153
  See <http://bugs.darcs.net/issue814>; memrchr speeds up is_funky  
quite a bit and thus helps whatsnew -s. It doesn't seem to break (any  
more) tests.
]

[configure: more precise error messages about packages.
Nicolas Pouillard <nicolas.pouillard@gmail.com>**20080424120226]

[SlurpDirectory.lhs: remove apparently pointless aliases
gwern0@gmail.com**20080428010950]

[implement primitive fixing of removal of non-empty files.
David Roundy <droundy@darcs.net>**20080428165532]

[add framework for patch-fixing repair.
David Roundy <droundy@darcs.net>**20080428153041]

[correct mmap type signatures
Jason Dagit <dagit@codersbase.com>**20080428190837]

[grammar fix
Ferenc Wagner <wferi@niif.hu>**20080426173243]

[add checks for removal of non-empty files.
David Roundy <droundy@darcs.net>**20080426120904]

[remove git section from building_darcs.tex
David Roundy <droundy@darcs.net>**20080424134245
  Thanks to Nicolas Pouillard for pointing this out.
]

[clean up genslurp_helper a tad.
David Roundy <droundy@darcs.net>**20080423214457
  I'm removing an unneeded unsafeInterleaveIO and am reformatting  
some of the
  indentation to make it clearer which else goes with which if.
]

[remove unneeded redundant adding of -lcurses (done by AC_SEARCH_LIBS).
David Roundy <droundy@darcs.net>**20080423214404]

[Give a clear error message when no suitable haddock is installed
tux_rocker@reinier.de**20080423172834]

[simplify configure a bit: if we're defining CPP symbols, no need to  
also use AC_SUBST.
David Roundy <droundy@darcs.net>**20080423152121]

[simplify makefile a bit.
David Roundy <droundy@darcs.net>**20080423150529]

[give proper error message when slurping fails to identify a file or  
directory.
David Roundy <droundy@darcs.net>**20080423141737]

[default to not coloring hunks.
David Roundy <droundy@darcs.net>**20080423141725]

[Use the lineColoring to prettify hunks with colors.
Nicolas Pouillard <nicolas.pouillard@gmail.com>**20080420135252]

[Add line coloring support in Printer and ColourPrinter.
Nicolas Pouillard <nicolas.pouillard@gmail.com>**20080420135238]

[Export Printer.(<?>).
Nicolas Pouillard <nicolas.pouillard@gmail.com>**20080420135208]

[Add two colors (cyan and magenta), but not use them yet.
Nicolas Pouillard <nicolas.pouillard@gmail.com>**20080420122811]

[Refactor a little the color handling.
Nicolas Pouillard <nicolas.pouillard@gmail.com>**20080420122500]

[slim down the makefile based on Gwern's changes to the configure  
script.
David Roundy <droundy@darcs.net>**20080423131854]

[configure.ac: export -lcurses for cabal
gwern0@gmail.com**20080420221056]

[configure.ac: export Curses as well
gwern0@gmail.com**20080420214353]

[Little style change.
Nicolas Pouillard <nicolas.pouillard@gmail.com>**20080420122143]

[Define unDoc as field of Doc.
Nicolas Pouillard <nicolas.pouillard@gmail.com>**20080416075954]

[Replace colour by color to uniformise a bit.
Nicolas Pouillard <nicolas.pouillard@gmail.com>**20080416074742]

[Canonize G. Branwen, P. Rockai, L. Komolodin and R. Lamers.
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080422152346
  All anonymous patches get assigned to Gwern.
]

[doc tweak
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080422151420]

[resolve issue809: doc: darcs get is not lazy by default.
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080422150809]

[doc: darcs-2 is no longer experimental.
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080422150736]

[Rename ColourPrinter to ColorPrinter.
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080421154043
  We might as well standardize on American spelling in the code.
]

[eliminate duplicate get_remote_repo in favor of list comprehensions.
David Roundy <droundy@darcs.net>**20080421145642]

[resolve issue792: Account for --remote-repo in defaultrepo code
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080421144023]

[Extend command_argdefaults to accept [DarcsFlag].
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080421143950]

[Add a --remote-repodir flag (yet unused).
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080421134352]

[Account for pre-existing api-doc.
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080421135155]

[Create the api-doc dir if it does not exist.
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080421134800]

[replace '{-# OPTIONS' with '{-# OPTIONS_GHC'
gwern0@gmail.com**20080419024027
  These OPTIONS pragmas use GHC-isms; best practice is to make them  
GHC specific if they are GHC specific.
  Specifically: -fglasgow-exts is obviously GHC only. -cpp is used  
only by GHC AFAIK - hugs uses some hugscpp, YHC uses '--cpp' as does  
presumably NHC, JHC doesn't support cpp, and no idea about the others.
  However, this patch omits modifying "src/Darcs/ColourPrinter.lhs",  
"src/Workaround.hs", and "src/win32/CtrlC.hs" because I was uncertain  
whether '-fno-warn-orphans', '-w', and '-ffi' are actually GHC-only.
]

[configure.ac: export -DHAVE_LIBWWW for CPP
gwern0@gmail.com**20080420213108]

[resolve issue795: Make 'darcs changes -i' behave more like other jobs.
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080421105247

  Old behaviour:
   Shall I continue to view changes?
     y - do not view this patch; keep going [DEFAULT]
     n - quit
     v - view this patch; keep going
     q - quit

  New behaviour:
    Shall I view this patch?
     y - view this patch; keep going
     n - do not view this patch; keep going [DEFAULT]
     v - view this patch; keep going
     q - quit
]

[Undo a false refactor in SelectChanges.
Eric Kow <E.Y.Kow@brighton.ac.uk>**20080421104106

  The new old code makes it clearer that text_view is only used by
  'view changes'
]

[Fix pluralization of patches using English module.
David Roundy <droundy@darcs.net>**20080421121716]

[configure.ac: move HAVE_CURL around
gwern0@gmail.com**20080420220800
  The dependency was inverted; we want to set HAVE_CURL before we  
test for Curl pipelining.
]

[optimized get --to-match handling for darcs 1 repositories
tux_rocker@reinier.de**20080420152608]

[stringify.hs: rw to avoid multi-line string literal
gwern0@gmail.com**20080419025648
  The reason we want to avoid multi-line string literals is because  
GHC and CPP can break them quite badly if accidentally applied.
  In addition, no one is going to read Context.hs - it exists solely  
to be compiled. So removing the multi-line business in favor of one  
long string which will look exactly the same in the compiled binary  
causes no problems. And it can fix a big one - if Context.hs can't be  
compiled, obviously Darcs cannot.
]

[configure.ac: restructure curl
gwern0@gmail.com**20080419020619
  We want to make sure HAVE_CURL shows up in CPP flags.
]

[configure.ac: +mention why threaded is not default/doc
gwern0@gmail.com**20080420023752]

[rearrange bytestring tests so if it's not present we're quieter.
David Roundy <droundy@darcs.net>**20080418212319]

[configure.ac: fix bytestring checking
gwern0@gmail.com**20080418205704
  This changes bytestring to be default. However it checks twice: if  
either --disable-bytestring is set or bytestring can't be found, it  
won't pass on CPP -DHAVE_BYTESTRING. So this should work for Dr.  
Roundy's lack of bytestring.
]

[remove unneeded check for termio.h.
David Roundy <droundy@darcs.net>**20080417172427]

[configure.ac: rm line
gwern0@gmail.com**20080416184604
  I can't even figure out how long ago Control.Monad was in a 'util'  
package.
]

[we don't need Darcs.Patch.Check for darcs itself.
David Roundy <droundy@darcs.net>**20080417150720]

[remove hackish attempt to set GC parameters based on available memory.
David Roundy <droundy@darcs.net>**20080416164105]

[define forM_ since it is absent on GHC 6.4.1
zooko@zooko.com**20080409234512]

[make darcs build on win32 by conditionally compiling out a few bits  
that are unused or meaningless on win32
zooko@zooko.com**20080410204830]

[Don't let other configure flags change the type witnesses
Lennart Kolmodin <kolmodin@gentoo.org>**20080415210614
  For example, when using --with-docs the type witnesses would be  
turned on,
  while with --without-docs they would not. This patch adresses this  
issue.
]

[eliminate use of Haskell 98 library modules.
David Roundy <droundy@darcs.net>**20080415214217]

[add type witness declarations to Resolution
David Roundy <droundy@darcs.net>**20080415165457]

[move -cpp option into source files.
David Roundy <droundy@darcs.net>**20080415144719]

[Issue a warning when using --old-fashioned-inventory with a darcs-2  
repository.
Nicolas Pouillard <nicolas.pouillard@gmail.com>**20080414232715]

[FastPackedString.hs: FastPackedString.hs: redefine linePS/unlinesPS
gwern0@gmail.com**20080414150839
  Turns out that my definitions were wrong - they differed and added  
a newline where the old FPS versions didn't. So I've rewritten the  
wrapper versions around ByteString, and checked them against the old  
ones with QuickCheck. With these fixes, a bytestring darcs seems to  
pass all the tests as a fps darcs.
]

[remove unused Setup.lhs.
David Roundy <droundy@darcs.net>**20080414190738]

[roll back implementation of joke oops command.
David Roundy <droundy@darcs.net>**20080414133342
  Apparently it didn't actually work...

  rolling back:

  Tue Apr  8 07:58:56 PDT 2008  David Roundy <droundy@darcs.net>
    * resolve issue786:  implement oops command.

      M ./src/Darcs/Commands/Tag.lhs -5 +47
      M ./src/Darcs/TheCommands.lhs -1 +2
]

[just remove concatLenPS
David Roundy <droundy@darcs.net>**20080411205303
  It is never used in a performance-critical situation, so I'm voting  
to just
  trash it.  I'd rather have fewer unsafe operations.
]

[FastPackedString.hs: simplify concatLenPS, although this removes its  
strictness properties
**20080411035327]

[FastPackedString.hs: remove wfindPS
**20080411035046
  With better imports from bytestring, I believe it to be  
superfluous, and dangerous to leave around.
]

[FastPackedString.hs: grmmr/sp
**20080411034730]

[FastPackedString.hs: rw linesPS using ByteString split
**20080411032229]

[doc updates
gwern0@gmail.com**20080409170824
  Convert all uses of 'http://darcs.net/repos/stable' to just  
darcs.net, since unstable and stable were merged together, and the  
old URL is a 404 for darcs getting. This is a real problem, see for  
example <http://reddit.com/info/6ewbq/comments/c03o6d5>.
]

[fix typo in show_bug_help
Matyas Janos <mjanos5@gmail.com>**20080408232600]

[Raise a configure error when no Text.Regex module can be found.
nicolas.pouillard@gmail.com**20080409085522]

[update README url links
gwern0@gmail.com**20080407201333]

[add a bit more debugging info to repository identification.
David Roundy <droundy@darcs.net>**20080408151912]

[resolve issue385: don't worry if we can't get local changes.
David Roundy <droundy@darcs.net>**20080408151823]

[add test for issue385.
David Roundy <droundy@darcs.net>**20080408151808]

[resolve issue786:  implement oops command.
David Roundy <droundy@darcs.net>**20080408145856]

[fix URL in network test.
David Roundy <droundy@darcs.net>**20080408145407]

[fix manual bug.
David Roundy <droundy@darcs.net>**20080407191736]

[add new show bug command (hidden) to see what darcs will report if  
we encounter a bug.
David Roundy <droundy@darcs.net>**20080407175410]

[automatically work out the version of the stable release.
David Roundy <droundy@darcs.net>**20080407171850]

[set prefs again (they got lost on convert).
David Roundy <droundy@darcs.net>**20080407171559]

[update darcs repository URL.
David Roundy <droundy@darcs.net>**20080407164601]

[fix up website for new release.
David Roundy <droundy@darcs.net>**20080407164010]

[simplify determine_release_state.pl.
David Roundy <droundy@darcs.net>**20080407153000]

[make determine_release_state.pl use changes --count.
David Roundy <droundy@darcs.net>**20080407152347]

[add --count output option to changes.
David Roundy <droundy@darcs.net>**20080407151825]

[TAG 2.0.0
David Roundy <droundy@darcs.net>**20080407150638]
msg4824 (view) Author: zooko Date: 2008-05-21.19:51:29
duplicate of issue871 (generated by e-mail-to-roundup, which likes to generate
duplicates to make sure we don't overlook anything)
History
Date User Action Args
2008-05-21 19:48:44zookocreate
2008-05-21 19:51:31zookosetpriority: bug
status: unread -> duplicate
superseder: + patch for darcs - fix for LCS
messages: + msg4824
nosy: tommy, beschmi, zooko, dagit
2009-08-06 21:05:38adminsetnosy: + dmitry.kurochkin, simon, kowey, thorkilnaur, - beschmi
2009-08-11 00:15:03adminsetnosy: - dagit
2009-08-25 18:11:16adminsetnosy: + darcs-devel, - simon
2009-08-27 13:59:45adminsetnosy: tommy, kowey, darcs-devel, zooko, thorkilnaur, dmitry.kurochkin