Here are patches that remove write support to OF repositories.

The first one is the least invaside, it removes the --old flag from
the commands get, init and put, which is not a very invasive change.

The second one is made from Petr Rockai's patch from the adventure branch.
The most important thing is that Darcs.Repository.DarcsRepo is renamed to
Darcs.Repository.Old, and this module now only exports the functions
readOldRepo and copyOldRepoPatches. Darcs.Repository.Pristine is removed.

I have verified that the commands get, pull and send worked with a remote
OF repository ( I took http://community.haskell.org/~ndm/darcs/cmdargs as
a test repo. )

However nothing is done so that darcs fails gracefully when a user tries
to work in an OF repo. This is probably something to be done only after
the darcs-cmdline / libdarcs separation takes place.

Also the test suite remains unmodified, so expect a lot of failures if
you run it with these patches.

2 patches for repository http://darcs.net/screened:

Sun Dec 12 00:21:47 CET 2010  Guillaume Hoffmann <guillaumh@gmail.com>
  * remove --old flag for init get and put, modify help accordingly

Thu Dec 16 16:40:11 CET 2010  Guillaume Hoffmann <guillaumh@gmail.com>
  * remove OF write support
  adapted from work by Petr Rockai

Attachments

• remove-__old-flag-for-init-get-and-put_-modify-help-accordingly.dpatch
• unnamed

Oops, this breaks optimize --upgrade. Working on that.

Two main differences with previous bundle version

* tests are modified so that they are all green now

* I reintroduced the revertTentativChanges function in Darcs.Repository.Old,
  otherwise the command "darcs optimize --upgrade" would be impossible to run
  safely (an alternative would be to make this command unsafe by no longer
  using withRepoLock).

8 patches for repository http://darcs.net/screened:

Fri Jan 21 18:32:29 CET 2011  Guillaume Hoffmann <guillaumh@gmail.com>
  * remove --old flag for init get and put, modify help accordingly

Fri Jan 21 19:06:58 CET 2011  Guillaume Hoffmann <guillaumh@gmail.com>
  * no longer test OF repositories

Sun Aug 29 19:15:18 CEST 2010  Petr Rockai <me@mornfall.net>
  * Modernize the conflict-doppleganger test.

Sun Aug 29 19:57:50 CEST 2010  Petr Rockai <me@mornfall.net>
  * Adapt issue1248 test to current OF-less situation.

Sun Aug 29 19:58:18 CEST 2010  Petr Rockai <me@mornfall.net>
  * Remove parts of the hashed_inventory that require conversion to OF.

Sat Jan 22 18:35:43 CET 2011  Guillaume Hoffmann <guillaumh@gmail.com>
  * remove OF write support
  adapted from work by Petr Rockai

Sat Jan 22 18:46:56 CET 2011  Guillaume Hoffmann <guillaumh@gmail.com>
  * modernize issue1984 test (patch by Petr Rockai)

Sat Jan 22 19:18:16 CET 2011  Guillaume Hoffmann <guillaumh@gmail.com>
  * remove some --hashed and --old flags from tests

Attachments

• remove-__old-flag-for-init-get-and-put_-modify-help-accordingly.dpatch
• unnamed

This new version makes Darcs fail on certain commands and functions
on OF repositories. This is done at two levels:

 * user interface level, see patch "add amInHashedRepository ..."
 * library level, see patch "remove OF write support"


12 patches for repository http://darcs.net/screened:

Fri Jan 21 18:32:29 CET 2011  Guillaume Hoffmann <guillaumh@gmail.com>
  * remove --old flag for init get and put, modify help accordingly

Fri Jan 21 19:06:58 CET 2011  Guillaume Hoffmann <guillaumh@gmail.com>
  * no longer test OF repositories

Sun Aug 29 19:15:18 CEST 2010  Petr Rockai <me@mornfall.net>
  * Modernize the conflict-doppleganger test.

Sun Aug 29 19:57:50 CEST 2010  Petr Rockai <me@mornfall.net>
  * Adapt issue1248 test to current OF-less situation.

Sun Aug 29 19:58:18 CEST 2010  Petr Rockai <me@mornfall.net>
  * Remove parts of the hashed_inventory that require conversion to OF.

Sat Jan 22 18:46:56 CET 2011  Guillaume Hoffmann <guillaumh@gmail.com>
  * modernize issue1984 test (patch by Petr Rockai)

Sat Jan 22 19:18:16 CET 2011  Guillaume Hoffmann <guillaumh@gmail.com>
  * remove some --hashed and --old flags from tests

Wed Feb  2 15:22:04 CET 2011  Guillaume Hoffmann <guillaumh@gmail.com>
  * add amInHashedRepository to disable OF-deprecated commands at the UI level

Wed Feb  2 16:06:38 CET 2011  Guillaume Hoffmann <guillaumh@gmail.com>
  * don't bother with testing issue1232
  fixing the test would imply adding another OF repo archive with prefs

Wed Feb  2 16:24:05 CET 2011  Guillaume Hoffmann <guillaumh@gmail.com>
  * update v1-braced.sh test to hashed format

Wed Feb  2 16:44:03 CET 2011  Guillaume Hoffmann <guillaumh@gmail.com>
  * test that OF disabled commands are disabled

Wed Feb  2 17:03:36 CET 2011  Guillaume Hoffmann <guillaumh@gmail.com>
  * remove OF write support
  Make low level pristine handling functions fail on OF repository
  by printing an error message.
  Adapted from work by Petr Rockai

Attachments

• remove-__old-flag-for-init-get-and-put_-modify-help-accordingly.dpatch
• unnamed
• unnamed

I wanted to say "fail gracefully", that is, by displaying an error
message that points to the page http://wiki.darcs.net/OF

Pushed to screen.

Self-pushed.