darcs

Patch 2100 proposed for new bugfix release 2.16.3

Bug Tracker Home

Issues
Show Unassigned
 Show All
Search Issues

Patches
Show Open
 Show All
Search Patches

Login




Register
Lost your login?

Help
Roundup docs

Title proposed for new bugfix release 2.16.3
Superseder Nosy List bfrk
Related Issues
Status obsoleted Assigned To
Milestone

Created on 2020-09-06.15:21:38 by bfrk, last changed 2020-11-14.16:48:12 by bfrk.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt bfrk, 2020-09-06.15:21:36 text/x-darcs-patch
patch-preview.txt bfrk, 2020-09-26.08:29:00 text/x-darcs-patch
patch-preview.txt bfrk, 2020-10-21.15:31:28 text/x-darcs-patch
unnamed bfrk, 2020-09-06.15:21:36 text/plain
unnamed bfrk, 2020-09-26.08:29:00 text/plain
unnamed bfrk, 2020-10-21.15:31:28 text/plain
work-around-cabal-stupidity-in-setup_hs.dpatch dead bfrk, 2020-09-06.15:21:36 application/x-darcs-patch
work-around-cabal-stupidity-in-setup_hs.dpatch bfrk, 2020-09-26.08:29:00 application/x-darcs-patch
work-around-cabal-stupidity-in-setup_hs.dpatch bfrk, 2020-10-21.15:31:28 application/x-darcs-patch
See mailing list archives for discussion on individual patches.
Messages
msg22450 (view) Author: bfrk Date: 2020-09-06.15:21:36 
I am proposing to make a new release, to fix issue2655 and a few other build
problems. This bundle is against branch-2.16.

8 patches for repository http://darcs.net/releases/branch-2.16:

patch bbcf629cc6f70383799da6b63a35eda990849f63
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat Aug 15 14:10:37 CEST 2020
  * work around cabal stupidity in Setup.hs
  
  Cabal insists that all files in extra-source-files must actually exist, even
  though only the cabal sdist command actually needs them.

patch 521fdbcb620a96c0e2f72d85281ea9fb7a1d8a68
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat Aug 15 15:20:31 CEST 2020
  * rollback "replace buildHook, haddockHook, and replHook with postConf"
  
  This was a mistake: with this change the Version.hs module will not be
  re-built when the repository changes.

patch 7ae9e49d92c88d4dcc94753ed2b5f478ac17a51e
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Aug 24 07:35:26 CEST 2020
  * resolve issue2655: PACKAGE_VERSION is not defined
  
  This happens only if darcs is build with the -fcurl flag. The patch adapts
  src/hscurl.hs to use CURRENT_PACKAGE_VERSION and include the definition from
  "cabal_macros.h".

patch 1c0c6788eb538e7112a655a97901e61261af300d
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Aug 24 07:55:49 CEST 2020
  * remove work-around for issue1824
  
  The underlying bug in ghc has been fixed a long time ago. Besides, the macro
  is no longer passed via command line but instead by including cabal_macros.h.

patch e00c99244cd348aab71992ff03f276782eb4e6e7
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Aug 24 12:57:52 CEST 2020
  * remove dependency on split package

patch ec178c29a623c2018f337d1c1a755d969802aea7
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Sep  6 13:34:50 CEST 2020
  * add changelog entries for 2.16.3

patch 0a758b61b6ec3bf681c11d703a2f0ca177a77d31
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Sep  6 13:35:26 CEST 2020
  * bump version to 2.16.3

patch a8d52b15dc830fb319d125e44a4b75b442220d78
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Sep  6 13:35:44 CEST 2020
  tagged 2.16.3
Attachments
msg22454 (view) Author: bfrk Date: 2020-09-26.08:29:00 
Here is an updated bundle that includes the fix for issue2654 and removal of
the dependency on sandi.

11 patches for repository http://darcs.net/releases/branch-2.16:

patch bbcf629cc6f70383799da6b63a35eda990849f63
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat Aug 15 14:10:37 CEST 2020
  * work around cabal stupidity in Setup.hs
  
  Cabal insists that all files in extra-source-files must actually exist, even
  though only the cabal sdist command actually needs them.

patch 521fdbcb620a96c0e2f72d85281ea9fb7a1d8a68
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat Aug 15 15:20:31 CEST 2020
  * rollback "replace buildHook, haddockHook, and replHook with postConf"
  
  This was a mistake: with this change the Version.hs module will not be
  re-built when the repository changes.

patch 7ae9e49d92c88d4dcc94753ed2b5f478ac17a51e
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Aug 24 07:35:26 CEST 2020
  * resolve issue2655: PACKAGE_VERSION is not defined
  
  This happens only if darcs is build with the -fcurl flag. The patch adapts
  src/hscurl.hs to use CURRENT_PACKAGE_VERSION and include the definition from
  "cabal_macros.h".

patch 1c0c6788eb538e7112a655a97901e61261af300d
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Aug 24 07:55:49 CEST 2020
  * remove work-around for issue1824
  
  The underlying bug in ghc has been fixed a long time ago. Besides, the macro
  is no longer passed via command line but instead by including cabal_macros.h.

patch e00c99244cd348aab71992ff03f276782eb4e6e7
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Aug 24 12:57:52 CEST 2020
  * remove dependency on split package

patch 0a758b61b6ec3bf681c11d703a2f0ca177a77d31
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Sep  6 13:35:26 CEST 2020
  * bump version to 2.16.3

patch 2f3c6267502d79c4762230b4282088d10c7386f7
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Sep 18 11:03:00 CEST 2020
  * drop dependency on sandi and use base16-bytestring >= 1.0
  
  This was prompted by the announcement of base16-bytestring-1.0.0.0 which
  claims to give major performance improvements and a simpler API. As we use
  sandi only for base16 en/decoding and already depended on base16-bytestring
  in addition to that, this seemed like a logical step. It also turned out
  that the API of base16-bytestring fits our conventions better, in particular
  we can drop the separate pass that converts between upper and lower case,
  which should give us further performance improvement.

patch 11df273ea16568590b493b01e25387bbda6512e3
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Aug 16 10:39:27 CEST 2020
  * resolve issue2654: amend --prompt-long-comment removes the long comment

patch a45c4852f662778927f8e5248957a9d06ab12204
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Aug 16 10:48:14 CEST 2020
  * improve the prompt when asking for a long comment
  
  We now ask whether they want to "add a" long comment or, if a prior log
  exists, "edit the" long comment.

patch 780d8da5453bd69c977aa2d61e78071c5abbd6e6
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Sep  6 13:34:50 CEST 2020
  * add changelog entries for 2.16.3

patch d3cf12cf8b5954ed586929f6dd1c814b93a3008b
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Sep 25 23:07:43 CEST 2020
  tagged 2.16.3
Attachments
msg22469 (view) Author: ganesh Date: 2020-10-16.21:40:33 
I've reviewed all the substantive patches in this bundle separately, this
looks good (though I'm afraid the changelog entry is wrongly dated due to
me being slow.)
msg22474 (view) Author: bfrk Date: 2020-10-17.08:47:54 
I will send an updated bundle with one or two additional patches anyway.
My usual procedure is to push the release-related patches to screened
only after I have actually committed the release, so I can make
last-minute amends like fixing the date.
msg22496 (view) Author: bfrk Date: 2020-10-21.15:31:28 
New bundle, hopefully the final one. It includes all patches from reviewed,
plus the changelog and the version bump. Will upload a release candidate
today.

34 patches for repository http://darcs.net/releases/branch-2.16:

patch bbcf629cc6f70383799da6b63a35eda990849f63
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat Aug 15 14:10:37 CEST 2020
  * work around cabal stupidity in Setup.hs
  
  Cabal insists that all files in extra-source-files must actually exist, even
  though only the cabal sdist command actually needs them.

patch 521fdbcb620a96c0e2f72d85281ea9fb7a1d8a68
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat Aug 15 15:20:31 CEST 2020
  * rollback "replace buildHook, haddockHook, and replHook with postConf"
  
  This was a mistake: with this change the Version.hs module will not be
  re-built when the repository changes.

patch 7ae9e49d92c88d4dcc94753ed2b5f478ac17a51e
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Aug 24 07:35:26 CEST 2020
  * resolve issue2655: PACKAGE_VERSION is not defined
  
  This happens only if darcs is build with the -fcurl flag. The patch adapts
  src/hscurl.hs to use CURRENT_PACKAGE_VERSION and include the definition from
  "cabal_macros.h".

patch 1c0c6788eb538e7112a655a97901e61261af300d
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Aug 24 07:55:49 CEST 2020
  * remove work-around for issue1824
  
  The underlying bug in ghc has been fixed a long time ago. Besides, the macro
  is no longer passed via command line but instead by including cabal_macros.h.

patch e00c99244cd348aab71992ff03f276782eb4e6e7
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Aug 24 12:57:52 CEST 2020
  * remove dependency on split package

patch 0a758b61b6ec3bf681c11d703a2f0ca177a77d31
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Sep  6 13:35:26 CEST 2020
  * bump version to 2.16.3

patch 2f3c6267502d79c4762230b4282088d10c7386f7
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Sep 18 11:03:00 CEST 2020
  * drop dependency on sandi and use base16-bytestring >= 1.0
  
  This was prompted by the announcement of base16-bytestring-1.0.0.0 which
  claims to give major performance improvements and a simpler API. As we use
  sandi only for base16 en/decoding and already depended on base16-bytestring
  in addition to that, this seemed like a logical step. It also turned out
  that the API of base16-bytestring fits our conventions better, in particular
  we can drop the separate pass that converts between upper and lower case,
  which should give us further performance improvement.

patch 11df273ea16568590b493b01e25387bbda6512e3
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Aug 16 10:39:27 CEST 2020
  * resolve issue2654: amend --prompt-long-comment removes the long comment

patch a45c4852f662778927f8e5248957a9d06ab12204
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Aug 16 10:48:14 CEST 2020
  * improve the prompt when asking for a long comment
  
  We now ask whether they want to "add a" long comment or, if a prior log
  exists, "edit the" long comment.

patch 2f4cea1a303b382053e9d6a2473ecc181768a5fe
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat Oct 17 19:10:57 CEST 2020
  * resolve issue2658: show dependencies should only show direct dependencies
  
  The code was written with that goal in mind, I just botched the way the
  direct and indirect dependencies are updated when a new dependency is found.

patch a1a6d933118b7fb751a8b41a6dcb682f810c7c1f
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Oct 19 10:28:12 CEST 2020
  * resolve issue2659: check for bad patch name after invoking editor, too

patch eddd7ae2b70d466f43a3b1008c615788033e3d05
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Oct 19 10:29:54 CEST 2020
  * D.UI.PatchHeader: define is_badname in terms of just_a_badname

patch d731955210c5716cadcd03ddcfef2fc5ea100de2
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Oct 19 10:30:44 CEST 2020
  * D.UI.PatchHeader: add "error" prefix to bad patch name error messages
  
  This makes it a bit clearer that the operation failed.

patch 2a577715e60faafe1f7194a9a8d9b9643760f0d6
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Oct 19 10:47:06 CEST 2020
  * fix and improve help text for show dependencies

patch dc9f5fc7d627f8dc8a5fae12f5dc3b16e1b1758d
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Oct 19 11:39:07 CEST 2020
  * improve internal documentation in D.UI.Commands.ShowDependencies
  
  This hopefully makes it clearer how the algorithm works.

patch 8f2405f53194c0b7e8352bd56c462000b32de683
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Oct 19 13:50:05 CEST 2020
  * add progress reporting to show dependencies command

patch defa429086b2847cca7df5efa87c86197182ac25
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Oct 19 13:50:51 CEST 2020
  * remove an obsolete TODO comment

patch f78c7fd9e7d3e88186665179bf07c5f183813fc7
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Sep 28 17:54:44 CEST 2020
  * harness: add XDG_CACHE_HOME to the env file

patch ea3eaee2d36efeec6e0b46c896531aca374650f3
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Sep 28 18:13:27 CEST 2020
  * tests/conflict-fight-failure.sh: skip test if system has no time executable

patch bbf7ff35ddcf92fd9233d9103eed0f31b2ccf498
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Oct 20 10:56:43 CEST 2020
  * tests/record.sh: fix tests for bad patch names
  
  It turned out that we do have a test for bad patch names even for the case
  where an editor is invoked, they were just utterly broken i.e. they did not
  test what they claimed to. Using DARCS_EDITOR='cat -n' defeats the purpose
  as this adds line numbers, so the patch name will always be valid. Also, if
  there is nothing to record, the command always fails, regardless of whether
  the patch name is valid or not.

patch 8414740be41d0825401c99ec313131f5aa258bed
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Oct 20 11:08:50 CEST 2020
  * tests/record.sh: remove directories before creating them

patch 87e9653f82f2242cde549e57a7b940d3ccfde6c6
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Oct 20 11:25:10 CEST 2020
  * add regression test for issue2659

patch f2113f9f9ff523f044afef7e64bca6687a4266b2
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Jul 31 22:41:22 CEST 2020
  * add (succeeding) test for issue2353

patch a6ebb72f5926f8ef2af860fcb46816e0f9ce5945
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat Aug  1 13:54:52 CEST 2020
  * resolve issue2570: coalesceHunk should take arguments in the natural order

patch 3a1500fc006cb7d96fd5927091650e05356f8e49
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat Aug  1 15:46:45 CEST 2020
  * add (succeeding) test for issue2549

patch bb4217e36fc21eda50b91639ff80430b54d5a803
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat Aug  1 18:17:20 CEST 2020
  * resolve issue1930: issue595_get_permissions.sh buggy

patch b0a1c375fe329928f34f81a879200aff2e7ac4a0
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Sep 23 12:33:09 CEST 2020
  * two bugfixes in the PrimV1 shrinker

patch fe2e433819a37d3722007a9f18ca6981379373dc
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Aug  2 01:50:35 CEST 2020
  * add (succeeding) test for issue1956

patch 646cd1486dce233245ee872f000a59bc3c8c44bd
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat Oct 17 10:34:52 CEST 2020
  * fix: make test for issue1956 succeed and no longer mark as failing

patch f4db57198c6e174658b9aa8891db6beb43f78a1b
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Jul 20 12:49:46 CEST 2020
  * Darcs.UI.Flags: add module haddocks

patch 563222c676a22aca83a24f1145727ddc19e558f9
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Jul 20 12:50:05 CEST 2020
  * Darcs.UI.Flags: reformat some of the code and comments

patch 1063e33c0952db1067a83de9c29fa24fd73515de
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Oct 21 14:45:13 CEST 2020
  * add a cabal.project file
  
  The cabal-3.2 tool by default scans subdirectories for cabal files. But we
  no longer treat the embedded shelly as a separate cabal package, so for
  cabal-3.2 we want to disable that. While cabal-3.4 changes the default back
  to ./*.cabal, it seems advisable not to rely on the defaults if they prove
  to be volatile.

patch f61a4de60386e743634d4053122f0eb649f99433
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Sep  6 13:34:50 CEST 2020
  * add changelog entries for 2.16.3

patch 2a6aff9d0e9679aade5d5f8a86fca97f6d9c10a4
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Oct 21 15:08:24 CEST 2020
  tagged 2.16.3
Attachments
History
Date User Action Args
2020-09-06 15:21:38bfrkcreate
2020-09-07 00:18:03bfrksettitle: work around cabal stupidity in Setup.hs (and 7 more) -> proposed for new bugfix release 2.16.3
2020-09-26 08:29:02bfrksetfiles: + patch-preview.txt, work-around-cabal-stupidity-in-setup_hs.dpatch, unnamed
messages: + msg22454
2020-10-16 21:40:33ganeshsetmessages: + msg22469
2020-10-17 08:47:55bfrksetmessages: + msg22474
2020-10-21 15:31:31bfrksetfiles: + patch-preview.txt, work-around-cabal-stupidity-in-setup_hs.dpatch, unnamed
messages: + msg22496
2020-11-14 16:48:12bfrksetstatus: needs-screening -> obsoleted